Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use docker compose instead of docker-compose #7018

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Conversation

adriansmares
Copy link
Contributor

Summary

This PR refactors our mage targets to use docker compose instead of docker-compose for Docker Compose related commands. docker-compose is the legacy command format and seems to be slowly phased out.

I had some failed GitHub Actions which failed because docker-compose was not found, hence this PR.

Changes

  • Use docker instead of docker-compose.
  • Prepend compose to all Docker Compose commands.

Testing

CI.

Regressions

N/A.

Notes for Reviewers

No need to review.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • The steps/process to test this feature are clearly explained including testing for regressions.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@adriansmares adriansmares added the bug Something isn't working label Apr 3, 2024
@adriansmares adriansmares added this to the v3.30.1 milestone Apr 3, 2024
@adriansmares adriansmares self-assigned this Apr 3, 2024
@github-actions github-actions bot added the tooling Development tooling label Apr 3, 2024
@adriansmares adriansmares marked this pull request as ready for review April 3, 2024 15:12
@adriansmares adriansmares requested a review from a team as a code owner April 3, 2024 15:12
@adriansmares adriansmares merged commit 43af3ad into v3.30 Apr 3, 2024
16 checks passed
@adriansmares adriansmares deleted the fix/docker-compose branch April 3, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tooling Development tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant