Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix switching between different ADR modes #7053

Merged
merged 2 commits into from Apr 29, 2024
Merged

Fix switching between different ADR modes #7053

merged 2 commits into from Apr 29, 2024

Conversation

ryaplots
Copy link
Contributor

Summary

This PR fixes the error found in testing in this comment: https://github.com/TheThingsIndustries/lorawan-stack-support/issues/1064#issuecomment-2082120568, point 7.

Changes

  • Check if dynamic is an adr before logic

Testing

  1. Login into the console
  2. Go to any device/create and application and device
  3. Go to device settings, to Network Server section and open the collapsed "Avanced MAC settings" section.
  4. Select ADR Dynamic mode.
  5. Uncheck Use default settings for number of retransmissions
  6. Click Add data rate specific override and add the data rate and NbTrans
  7. Then save changes. The specific override should be saved.
  8. Select ADR disabled and save changes.
  9. Refresh the page and see that the ADR mode is disabled.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@ryaplots ryaplots added bug Something isn't working ui/web This is related to a web interface labels Apr 29, 2024
@ryaplots ryaplots self-assigned this Apr 29, 2024
@ryaplots ryaplots requested a review from a team as a code owner April 29, 2024 09:43
@ryaplots ryaplots added this to the v3.30.1 milestone Apr 29, 2024
@ryaplots ryaplots merged commit 0975a05 into v3.30 Apr 29, 2024
13 checks passed
@ryaplots ryaplots deleted the fix/adr-logic branch April 29, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants