Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
References #6483
In short,
/users/bookmarks
can be interpreted as a request towards the user calledbookmarks
. The only reason why this doesn't happen is that methods don't overlap - bookmark creation usesPOST
while user updates requirePUT
.The API itself is very hierarchical - sub-entities generally contain the top level entity ID in the path in order to avoid these possible path overlaps, and this should apply here as well.
Changes
UserRegistry
HTTP paths do not overlap withUserBookmarkRegistry
HTTP paths.Testing
N/A. This just changes the generated code. No testing required.
Regressions
N/A. The Console does not depend on this feature, and the CLI clients are unaffected as they use gRPC.
It may be tempting to say that this API has already been released and is frozen, but there are no real clients for it, so it's better to fix this now than later.
Checklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.