Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Example with Field Mask #81

Merged
merged 1 commit into from
May 5, 2023
Merged

Update Example with Field Mask #81

merged 1 commit into from
May 5, 2023

Conversation

philippdzm
Copy link
Contributor

Summary

I am updating the example.yml with the fiel mask item from:
https://www.thethingsindustries.com/docs/integrations/webhooks/webhook-templates/format/#field-mask

Changes

I am not sure weather field-mask contains a sequence or a mapping. I assumed sequence and did the changes accordingly.

Notes for Reviewers

  • Please make sure this PR is correct. It will service as the only example for how to configure field-mask.
  • Is there a way to test?

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible, they don't break existing deployments.
  • Testing: The changes are tested.
  • Documentation: Relevant documentation is added or updated.

@github-actions github-actions bot added the needs/triage We still need to triage this label May 4, 2023
adriansmares
adriansmares approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@adriansmares adriansmares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is indeed the case that field-mask is a sequence. I have added a commit to the schema validation to check the type.

The proposed changes look good to me.

@adriansmares adriansmares merged commit 03a05eb into TheThingsNetwork:master May 5, 2023
2 checks passed
@philippdzm philippdzm deleted the update-example-webhook branch May 8, 2023 10:54
@philippdzm
Copy link
Contributor Author

philippdzm commented May 8, 2023 •
edited

I have added a commit to the schema validation to check the type.

nice, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriansmares adriansmares adriansmares approved these changes

@nejraselimovic nejraselimovic Awaiting requested review from nejraselimovic nejraselimovic is a code owner

Assignees
No one assigned
Labels
needs/triage We still need to triage this
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@philippdzm @adriansmares