Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create new pilot-things template #85

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Create new pilot-things template #85

merged 1 commit into from
Aug 24, 2023

Conversation

Youngcheol-Shin
Copy link

Summary

This file is a template file for integrating with the Pilot Things system.

Changes

  • Initial version
  • The data received from TTI has been implemented and tested

Checklist

  • [V] Scope: The referenced issue is addressed, there are no unrelated changes.
  • [V] Compatibility: The changes are backwards compatible, they don't break existing deployments.
  • [V] Testing: The changes are tested.
  • [V] Documentation: Relevant documentation is added or updated.

@CLAassistant
Copy link

CLAassistant commented Aug 14, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the needs/triage We still need to triage this label Aug 14, 2023
@Youngcheol-Shin
Copy link
Author

The CL:A document was signed but this pull request is still pending. Could you check it?

nejraselimovic
nejraselimovic approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@nejraselimovic nejraselimovic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, did you document this integration by any chance?

@nejraselimovic nejraselimovic removed the needs/triage We still need to triage this label Aug 24, 2023
@github-actions github-actions bot added the needs/triage We still need to triage this label Aug 24, 2023
@nejraselimovic nejraselimovic removed the needs/triage We still need to triage this label Aug 24, 2023
@nejraselimovic
Copy link
Contributor

Looks good to me, not sure why the CLA is still pending though, maybe @adriansmares knows? Also, did you document this integration by any chance?

@adriansmares
Copy link
Contributor

I believe the issue is that the commits are created by https://github.com/syc0701 while the PR is created by https://github.com/Youngcheol-Shin - could you please try to sign the CLA from both accounts ?

@Youngcheol-Shin
Copy link
Author

Thank you adriansmares.

@adriansmares adriansmares merged commit b7fe175 into TheThingsNetwork:master Aug 24, 2023
3 checks passed
@Jaime-Trinidad Jaime-Trinidad mentioned this pull request Nov 22, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nejraselimovic nejraselimovic nejraselimovic approved these changes

@adriansmares adriansmares Awaiting requested review from adriansmares

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Youngcheol-Shin @CLAassistant @nejraselimovic @adriansmares @syc0701