Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve readChar #191

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Improve readChar #191

wants to merge 6 commits into from

Commits on Aug 7, 2023

  1. Test.java: fix #stdin marker

    @privat
    privat committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    b001241 View commit details
    Browse the repository at this point in the history

  2. Test: add test for ReadString and Read

    @privat
    privat committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    dbb8677 View commit details
    Browse the repository at this point in the history

  3. SystemIO::readChar do not truncate on console 

    Also, return -1 on EOF instead of aborting,
so EOF can be managed in asm programs/

Note readChar can also read newlines characters and act on it
    @privat
    privat committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    a3ce09c View commit details
    Browse the repository at this point in the history

  4. SyscallReadChar: upate documentation to talk about EOF

    @privat
    privat committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    cf7490b View commit details
    Browse the repository at this point in the history

  5. SyscallReadString: fix documentation as a1 is the size of the buffer

    @privat
    privat committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    d8dcae0 View commit details
    Browse the repository at this point in the history

  6. add test/readchar.s

    @privat
    privat committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    8eb221a View commit details
    Browse the repository at this point in the history