Skip to content
This repository has been archived by the owner on Mar 2, 2022. It is now read-only.

Use txtorcon web agent #101

Merged
merged 10 commits into from
Mar 23, 2018
Merged

Use txtorcon web agent #101

merged 10 commits into from
Mar 23, 2018

Conversation

aagbsn
Copy link
Collaborator

@aagbsn aagbsn commented Mar 20, 2018

Throws out a bunch of code that is now supported by txtorcon directly.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.9%) to 62.419% when pulling 516104b on use_txtorcon_web_agent into cd023b2 on develop.

@coveralls
Copy link

coveralls commented Mar 20, 2018

Coverage Status

Coverage remained the same at 64.629% when pulling 8c902e6 on use_txtorcon_web_agent into 97f93b6 on develop.

@aagbsn
Copy link
Collaborator Author

aagbsn commented Mar 20, 2018

This is breaking because I rebased it on top of devel; and tests using hashingReadBody fail because the expected checksum doesn't match expected from the unit tests.

@juga0
Copy link
Collaborator

juga0 commented Mar 21, 2018

With my changes tests are not failing (locally) because hashes don't match, but they fail sometimes because circuits fail:

    assert not failed_measurements
exceptions.AssertionError

The measurement file contains:

u'failure': u"<twisted.python.failure.Failure exceptions.Exception: Circuit failed ('CHANNEL_CLOSED')>"

to match the dummy data received.
@juga0
Copy link
Collaborator

juga0 commented Mar 21, 2018

I don't know how to reproduce it, but sometimes tests fail locally with:

Traceback (most recent call last):
  File "/home/user/bwscanner/test/test_writer.py", line 36, in <lambda>
    dl.addCallback(lambda results: walk(self.tmpdir, validate, None))
  File "/home/user/bwscanner/.tox/py27/lib/python2.7/posixpath.py", line 231, in walk
    func(arg, top, names)
  File "/home/user/bwscanner/test/test_writer.py", line 26, in validate
    assert len(fnames) == num_chunks
exceptions.AssertionError: 

test.test_writer.TestResultSink.test_send_multiple_chunk_size

Copy link
Member

@meejah meejah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me. I don't know why some circuits are failing -- could it be a Chutney thing? In any case that seems worth investigating.

@juga0 juga0 merged commit c77c600 into develop Mar 23, 2018
@juga0
Copy link
Collaborator

juga0 commented Mar 23, 2018

Meged, i'll open other issues after confirming this still happens

@juga0 juga0 deleted the use_txtorcon_web_agent branch March 23, 2018 10:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants