This repository has been archived by the owner on Mar 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces our OnionRoutedAgent and txsocksx
516104b
to
c661f8f
Compare
This is breaking because I rebased it on top of devel; and tests using hashingReadBody fail because the expected checksum doesn't match expected from the unit tests. |
With my changes tests are not failing (locally) because hashes don't match, but they fail sometimes because circuits fail:
The measurement file contains:
|
to match the dummy data received.
ec9a6a1
to
8c902e6
Compare
I don't know how to reproduce it, but sometimes tests fail locally with:
|
meejah
approved these changes
Mar 21, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good to me. I don't know why some circuits are failing -- could it be a Chutney thing? In any case that seems worth investigating.
Meged, i'll open other issues after confirming this still happens |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throws out a bunch of code that is now supported by txtorcon directly.