Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More code-janitor work #42

Merged
merged 15 commits into from
Apr 21, 2014
Merged

More code-janitor work #42

merged 15 commits into from
Apr 21, 2014

Commits on Apr 15, 2014

  1. clearer check_paths()

    @darius
    darius committed Apr 15, 2014
    Configuration menu
    Copy the full SHA
    562649f View commit details
    Browse the repository at this point in the history

  2. simpler methods in Storage

    @darius
    darius committed Apr 15, 2014
    Configuration menu
    Copy the full SHA
    f5001bd View commit details
    Browse the repository at this point in the history

  3. fix doctest (python -m doctest __init__.py was failing)

    @darius
    darius committed Apr 15, 2014
    Configuration menu
    Copy the full SHA
    9c14a5d View commit details
    Browse the repository at this point in the history

  4. simpler Config.load()

    @darius
    darius committed Apr 15, 2014
    Configuration menu
    Copy the full SHA
    01c410b View commit details
    Browse the repository at this point in the history

  5. remove unused (and confusing) global

    @darius
    darius committed Apr 15, 2014
    Configuration menu
    Copy the full SHA
    1c1e3d7 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2014

  1. clearer logic by eliminating checking_first_packet and bringing assig… 

    …nments to the same variable closer together
    @darius
    darius committed Apr 16, 2014
    Configuration menu
    Copy the full SHA
    6ce07eb View commit details
    Browse the repository at this point in the history

  2. remove duplicate import

    @darius
    darius committed Apr 16, 2014
    Configuration menu
    Copy the full SHA
    529fe95 View commit details
    Browse the repository at this point in the history

  3. note missing import

    @darius
    darius committed Apr 16, 2014
    Configuration menu
    Copy the full SHA
    238ea56 View commit details
    Browse the repository at this point in the history

  4. a more-direct test

    @darius
    darius committed Apr 16, 2014
    Configuration menu
    Copy the full SHA
    38048f6 View commit details
    Browse the repository at this point in the history

  5. move write() out of the scope of an IOError catch clause not meant fo… 

    …r it
    @darius
    darius committed Apr 16, 2014
    Configuration menu
    Copy the full SHA
    92379c1 View commit details
    Browse the repository at this point in the history

  6. tighter try/except/with blocks

    @darius
    darius committed Apr 16, 2014
    Configuration menu
    Copy the full SHA
    bb924d9 View commit details
    Browse the repository at this point in the history

  7. tighter try/except/with blocks

    @darius
    darius committed Apr 16, 2014
    Configuration menu
    Copy the full SHA
    fe398cd View commit details
    Browse the repository at this point in the history

  8. remove overbroad try/except

    @darius
    darius committed Apr 16, 2014
    Configuration menu
    Copy the full SHA
    eae427c View commit details
    Browse the repository at this point in the history

  9. try/except is not needed here

    @darius
    darius committed Apr 16, 2014
    Configuration menu
    Copy the full SHA
    c543fee View commit details
    Browse the repository at this point in the history

  10. remove mutable class-level variable that's always overridden by a fre… 

    …sh instance variable with the same name (at least within this code, and I'm going to assume that's how it's meant to be used)
    @darius
    darius committed Apr 16, 2014
    Configuration menu
    Copy the full SHA
    5a21e98 View commit details
    Browse the repository at this point in the history