feat: infer the outputPath option from the options.outputPath of …
#53
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit ff0df2e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
…the specified `buildTarget` closes TheUnderScorer#52
tinesoft
force-pushed
the
feat/infer-output-path
branch
from
8fea2d2
to
e68c9b9
Compare
|
Thanks a lot for the pr @tinesoft! Could you add at least one test for this feature? |
|
Yeah sorry for the missing test... I wanted to add (e2e) tests, but I could not manage to have a basic existing e2e to work ( timeout issue in jest)... This is a open bug in Nx that appeared since v15.x.x... Can you run e2e on your local machine? |
|
Yep, they work for me locally. If it's a problem, you can try to add at least some basic test and run it through CI, I can improve it later :) |
|
Ok, I will try to do that and update the PR :-) |
| @@ -99,7 +103,7 @@ export async function semanticRelease( | |||
| /** | |||
| * @FIXME Recently semantic-release became esm only, but until NX will support plugins in ESM, we have to use this dirty hack :/ | |||
| * */ | |||
| function getSemanticRelease() { | |||
| export/** for testing only!*/ function getSemanticRelease() { | |||
There was a problem hiding this comment.
I have added a basic test for the semnatic-releaseexecutor, but I was NOt able to make it work, specially because I didnt find a way to mock the ESM module...
Any help here is weelcome !
There was a problem hiding this comment.
Thanks for that! I will try to take a look at it when I will have a moment 😄
…the specified
buildTarget