Fixed security issue in upload system. #52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allowing users to have the text "../" inside a filename allows them to escape the folder scope and essentially navigate anywhere they please if they can guess the filesystems structure.
TheWaWaR
reviewed
Feb 23, 2021
| status::Forbidden, | ||
| format!("Using filename to elevate folder scope is forbidden."), | ||
| )); | ||
| } |
There was a problem hiding this comment.
Check if the absolute final path is the sub-path of absolute root_path is a better idea.
There was a problem hiding this comment.
I'm not familiar enough with the codebase or these libraries to find a clean way to do what you want. I will close this PR.
… file outside of the fileserver's root scope. Previously one could abuse the ability to create a custom filename like: "../file.txt" to place files in any path they could guess.
|
Cancel what I said earlier, it was simpler than I thought. Take a close look at what I did because I'm not 100% that I did it correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing users to have the text "../" inside a filename allows them to escape the folder scope and essentially navigate anywhere they please if they can guess the filesystem's structure.