Merge pull request #1654 from 24i/feature/fix-when-muted-and-controls

[iOS] fix when controls & muted
TheWidlarzGroup · Jul 8, 2019 · 77c9ad3 · 77c9ad3
2 parents be3c8b6 + eae487c
commit 77c9ad3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,7 @@
 ## Changelog
 
 ### Version 4.4.3
+* Fix mute/unmute when controls are present (iOS) [#1654](https://github.com/react-native-community/react-native-video/pull/1654)
 * Fix Android videos being able to play with background music/audio from other apps.
 * Fixed memory leak on iOS when using `controls` [#1647](https://github.com/react-native-community/react-native-video/pull/1647)
 * (Android) Update gradle and target SDK [#1629](https://github.com/react-native-community/react-native-video/pull/1629)

diff --git a/ios/Video/RCTVideo.m b/ios/Video/RCTVideo.m
@@ -957,7 +957,9 @@ - (void)setMaxBitRate:(float) maxBitRate {
 - (void)applyModifiers
 {
   if (_muted) {
-    [_player setVolume:0];
+    if (!_controls) {
+      [_player setVolume:0];
+    }
     [_player setMuted:YES];
   } else {
     [_player setVolume:_volume];