Skip to content

Commit

Permalink
Merge pull request #1720 from nmarisi/fix-NSInternalInconsistencyExce…
Browse files Browse the repository at this point in the history
…ption

Removing the call to observeValueForKeyPath:ofObject:change:context: …
  • Loading branch information
CHaNGeTe committed Sep 8, 2019
2 parents 0a2f7bd + 9272678 commit f66ca32
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
## Changelog

### Version 5.0.2
* Fix crash when RCTVideo's superclass doesn't observe the keyPath 'frame' (iOS) [#1720](https://github.com/react-native-community/react-native-video/pull/1720)

### Version 5.0.1
* Fix AndroidX Support bad merge

Expand Down
2 changes: 0 additions & 2 deletions ios/Video/RCTVideo.m
Original file line number Diff line number Diff line change
Expand Up @@ -712,8 +712,6 @@ - (void)observeValueForKeyPath:(NSString *)keyPath ofObject:(id)object change:(N

return;
}
} else if ([super respondsToSelector:@selector(observeValueForKeyPath:ofObject:change:context:)]) {
[super observeValueForKeyPath:keyPath ofObject:object change:change context:context];
}
}

Expand Down

0 comments on commit f66ca32

Please sign in to comment.