Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Allow to configure styles for subtitle track #3662

Closed
Sumeeth-24 opened this issue Apr 7, 2024 · 4 comments
Closed

[Feature]: Allow to configure styles for subtitle track #3662

Sumeeth-24 opened this issue Apr 7, 2024 · 4 comments
Labels

Comments

@Sumeeth-24
Copy link

Description

Presently, our subtitle tracks lack the functionality to incorporate custom styles. Consequently, users encounter an inconvenience when attempting to pinch zoom to full screen, as the subtitle style becomes cropped and renders the subtitle track unreadable. For instance, if there are three lines of subtitles, upon entering full screen mode, only one line remains visible while the remaining two lines disappear below the screen. To address this issue, we require a solution that enables control over various configurations such as padding bottom, top, and other attributes. Additionally, implementing features like automatically centering subtitles when the video controller appears and shifting them downward when the controller is hidden would significantly enhance user experience. Therefore, the primary focus should be on introducing the basic feature of custom style customization for subtitle tracks.

Why it is needed ?

Users encounter an inconvenience when attempting to pinch zoom to full screen, as the subtitle style becomes cropped and renders the subtitle track unreadable. For instance, if there are three lines of subtitles, upon entering full screen mode, only one line remains visible while the remaining two lines disappear below the screen.

Possible implementation

Probably need additional props and make changes in native code.

Code sample

Code sample

@freeboub
Copy link
Collaborator

@freeboub
Copy link
Collaborator

@Sumeeth-24 Is the linked PR answer to your issue ?

@Sumeeth-24
Copy link
Author

Sumeeth-24 commented May 28, 2024 via email

@freeboub
Copy link
Collaborator

fix will be available in 6.1.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants