Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent errors on iOS when using text tracks with caching #1172

Merged
merged 8 commits into from
Aug 28, 2018
Merged

Prevent errors on iOS when using text tracks with caching #1172

merged 8 commits into from
Aug 28, 2018

Commits on Aug 8, 2018

  1. Rework logic for extension detection

    @cobarx
    cobarx committed Aug 8, 2018
    Configuration menu
    Copy the full SHA
    9d22835 View commit details
    Browse the repository at this point in the history

  2. Code style cleanups

    @cobarx
    cobarx committed Aug 8, 2018
    Configuration menu
    Copy the full SHA
    8084b16 View commit details
    Browse the repository at this point in the history

  3. Refactor to move caching code into a single block

    @cobarx
    cobarx committed Aug 8, 2018
    Configuration menu
    Copy the full SHA
    86d655c View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2018

  1. Bypass cache when sideloaded text tracks are specified 

    Fixes a crash when using the cache & sideloaded text tracks together due to the tracks on the asset not being available. Re-visit when someone with more expertise on the cache can look at it.
    @cobarx
    cobarx committed Aug 28, 2018
    Configuration menu
    Copy the full SHA
    a26dc26 View commit details
    Browse the repository at this point in the history

  2. Simplify text track + cache bypass code

    @cobarx
    cobarx committed Aug 28, 2018
    Configuration menu
    Copy the full SHA
    b6ee8f7 View commit details
    Browse the repository at this point in the history

  3. Add debug message when disabling caching due to text tracks

    @cobarx
    cobarx committed Aug 28, 2018
    Configuration menu
    Copy the full SHA
    67a3889 View commit details
    Browse the repository at this point in the history

  4. Provide info about caching not working with text tracks

    @cobarx
    cobarx committed Aug 28, 2018
    Configuration menu
    Copy the full SHA
    152978d View commit details
    Browse the repository at this point in the history

  5. Remove old test var

    @cobarx
    cobarx committed Aug 28, 2018
    Configuration menu
    Copy the full SHA
    b6512e4 View commit details
    Browse the repository at this point in the history