Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] fix when controls & muted #1654

Merged
merged 3 commits into from
Jul 8, 2019
Merged

[iOS] fix when controls & muted #1654

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
576273d
fix when controls & muted
Jul 6, 2019
61a72ad
update changelog
Jul 6, 2019
eae487c
Merge branch 'release/4.4.3' into feature/fix-when-muted-and-controls
CHaNGeTe Jul 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
## Changelog

### Version 4.4.3
* Fix mute/unmute when controls are present (iOS) [#1654](https://github.com/react-native-community/react-native-video/pull/1654)
* Fix Android videos being able to play with background music/audio from other apps.
* Fixed memory leak on iOS when using `controls` [#1647](https://github.com/react-native-community/react-native-video/pull/1647)
* (Android) Update gradle and target SDK [#1629](https://github.com/react-native-community/react-native-video/pull/1629)
Expand Down
4 changes: 3 additions & 1 deletion ios/Video/RCTVideo.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -957,7 +957,9 @@ - (void)setMaxBitRate:(float) maxBitRate {
- (void)applyModifiers
{
if (_muted) {
[_player setVolume:0];
if (!_controls) {
[_player setVolume:0];
}
[_player setMuted:YES];
} else {
[_player setVolume:_volume];
Expand Down