Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix video dimensions for HLS streams #1992

Merged
merged 3 commits into from
May 5, 2020
Merged

Fix video dimensions for HLS streams #1992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cc2e9c4
Fix video dimensions for HLS streams
jenshandersson May 5, 2020
4bc2a72
Changelog
jenshandersson May 5, 2020
08c7aaa
Compare CGFloats instead
jenshandersson May 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
### Version 5.1.0-alpha6

- Fix iOS bug which would break size of views when video is displayed with controls on a non full-screen React view. [#1931](https://github.com/react-native-community/react-native-video/pull/1931)
- Fix video dimensions being undefined when playing HLS in ios. [#1992](https://github.com/react-native-community/react-native-video/pull/1992)

### Version 5.1.0-alpha5

Expand Down
4 changes: 4 additions & 0 deletions ios/Video/RCTVideo.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,6 +638,10 @@ - (void)observeValueForKeyPath:(NSString *)keyPath ofObject:(id)object change:(N
} else {
orientation = @"portrait";
}
} else if (_playerItem.presentationSize.height) {
width = [NSNumber numberWithFloat:_playerItem.presentationSize.width];
height = [NSNumber numberWithFloat:_playerItem.presentationSize.height];
orientation = _playerItem.presentationSize.width > _playerItem.presentationSize.height ? @"landscape" : @"portrait";
}

if (self.onVideoLoad && _videoLoadStarted) {
Expand Down