Backport Fixes for react 0.69.X on branch react-native-video 5.2 #2795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with React Native 0.68, using Prop Types from `react-native` emits a warning.
Co-authored-by: Elliott Kember <elliott.kember@gmail.com> # Conflicts: # Video.js
# Conflicts: # Video.js
This was referenced Aug 1, 2022
freeboub
changed the title
This was referenced Aug 5, 2022
|
Tested on 0.69.4 and it's working ✔️ |
rafaelbrun
approved these changes
Aug 11, 2022
|
+1 we need this update ASAP 🙏 , tested in 0.69.4 |
|
When is this going in?? |
|
Should done during next week |
CDBridger
reviewed
Aug 16, 2022
| @@ -22,5 +22,5 @@ android { | |||
| dependencies { | |||
| //noinspection GradleDynamicVersion | |||
| implementation "com.facebook.react:react-native:${safeExtGet('reactNativeVersion', '+')}" | |||
| implementation 'com.yqritc:android-scalablevideoview:1.0.4' | |||
| implementation 'com.github.adityaxjha:Android-ScalableVideoView:10e7b4da8b' | |||
|
This pull request fixes the problem #2818 that I was having. |
|
Can we please merge this? a real world app is depending on this issue, not working the alpha branch. |
This was referenced Sep 4, 2022
NiharR27
approved these changes
Sep 13, 2022
|
This PR is now branch 5.2.X, let's close it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes