feat: add typescript #3266
Merged
feat: add typescript #3266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freeboub
requested changes
Oct 3, 2023
|
Great 👍 a lot of minor comments but looks good |
KrzysztofMoch
force-pushed
the
feat/add-typescript
branch
from
000da0f
to
c4de22e
Compare
KrzysztofMoch
force-pushed
the
feat/add-typescript
branch
from
c4de22e
to
bf435c7
Compare
|
sorry @KrzysztofMoch I merge the DRM PR, so there are conflict with this one ... |
KrzysztofMoch
force-pushed
the
feat/add-typescript
branch
from
bf435c7
to
3f22522
Compare
freeboub
approved these changes
Oct 6, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR add built-in types and configuration for typescript. It is also step to prepare for new architecture support (codegen). Changes and types are based on New Arch PR by @yungblud
Why is needed ?
With built-in types we have up to date types on every version and we don't need to install an rely on additional package for types
@types/react-native-video. Overall built-in types increase the comfort of both developers and maintainers.But
@types/react-native-videoshould stay to support older versions ofreact-native-videoHow to test ?
yarn buildVideocomponent should be available