Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove false calls at onPlaybackRateChange #3306

Merged
merged 1 commit into from
Oct 24, 2023
Merged

fix: remove false calls at onPlaybackRateChange #3306

merged 1 commit into from
Oct 24, 2023

Conversation

KrzysztofMoch
Copy link
Collaborator

@KrzysztofMoch KrzysztofMoch commented Oct 23, 2023 •
edited

Summary

Don't emit event onPlaybackRateChange if value is same as in previous call - like on android

Test plan

  • run example & check if callback is working correctly

@KrzysztofMoch KrzysztofMoch mentioned this pull request Oct 23, 2023
Merged
1 task
@freeboub
Copy link
Collaborator

Looks good to me, @KrzysztofMoch can you fix the conflicts please ?

@KrzysztofMoch
Copy link
Collaborator Author

Looks good to me, @KrzysztofMoch can you fix the conflicts please ?

Done ✅

@freeboub freeboub merged commit 286418e into TheWidlarzGroup:master Oct 24, 2023
1 check passed
@KrzysztofMoch KrzysztofMoch deleted the fix/on-playback-rate-chnage branch October 26, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freeboub freeboub freeboub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KrzysztofMoch @freeboub