feat(ios): add onBandwidthUpdate event #3331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freeboub
reviewed
Nov 4, 2023
freeboub
reviewed
Nov 4, 2023
freeboub
reviewed
Nov 4, 2023
| export type OnBandwidthUpdateData = Readonly< | ||
| | { | ||
| bitrate: number; | ||
| width: number; |
There was a problem hiding this comment.
same here width?: number;
There was a problem hiding this comment.
But here i would like to leave it like this, it will be easier for user - if width is not null it means that height is also not null. Correct me if I am wrong
There was a problem hiding this comment.
ok, no problem, and yes you are right, if wifth is ull height is null also
freeboub
reviewed
Nov 4, 2023
freeboub
reviewed
Nov 4, 2023
Co-authored-by: Olivier Bouillet <62574056+freeboub@users.noreply.github.com>
Co-authored-by: Olivier Bouillet <62574056+freeboub@users.noreply.github.com>
Co-authored-by: Olivier Bouillet <62574056+freeboub@users.noreply.github.com>
freeboub
reviewed
Nov 6, 2023
Co-authored-by: Olivier Bouillet <62574056+freeboub@users.noreply.github.com>
|
1 small additional clean needed, sorry :) |
freeboub
approved these changes
Nov 8, 2023
|
merged for alpha.10 ticket: #1726 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add onBandwidthUpdate event
backport of #1745
Test plan