fix(android): fix leak caused by removing lifecycle listener too early #3380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BasixKOR
changed the title
BasixKOR
changed the title
|
It make sense, looks like it will fix a lot of strange behavior ! |
freeboub
approved these changes
Nov 23, 2023
KrzysztofMoch
approved these changes
Nov 23, 2023
JasonZhuSky
pushed a commit
to skytvnz/react-native-video
that referenced
this pull request
Apr 25, 2024
TheWidlarzGroup#3380) * Fix lifecycle listener being removed too early
JasonZhuSky
added a commit
to skytvnz/react-native-video
that referenced
this pull request
Apr 25, 2024
…too early (TheWidlarzGroup#3380)" This reverts commit 67230c6.
JasonZhuSky
pushed a commit
to skytvnz/react-native-video
that referenced
this pull request
Apr 25, 2024
TheWidlarzGroup#3380) * Fix lifecycle listener being removed too early
JasonZhuSky
added a commit
to skytvnz/react-native-video
that referenced
this pull request
Apr 25, 2024
TheWidlarzGroup#3380) (#95) * Fix lifecycle listener being removed too early Co-authored-by: Sung Jeon <basix@basix.tech>
JasonZhuSky
pushed a commit
to skytvnz/react-native-video
that referenced
this pull request
May 9, 2024
TheWidlarzGroup#3380) * Fix lifecycle listener being removed too early
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some cases where the lifecycle event listeners are removed before it receives
onHostDestroy, causing the app to not release the resource when some other methods such assetBufferConfig.Possible leak scenario
<Video />mounts.ReactExoplayerViewis created.bufferConfigprop is changed, calling theReactExoplayerViewManager.setBufferConfig,ReactExoplayerView.setBufferConfig,ReactExoplayerView.releasePlayerin order.releasePlayerremoves the activity lifecycle listener, causing it to not receiveonHostDestroyproperly.releasePlayer.