fix: check for ios url query encoding #3384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freeboub
approved these changes
Nov 26, 2023
|
Be careful @JuozasP I revert your PR as it causes some bad behavior. Please url encode your props before passing it to rnv. I also added a note in doc for tjis behavior. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds url encoding for ios and fixes an old issue #1566. Loading a video with spaces in the URL on a physical iOS device fails and results in endless spinner
Example
<Video source={{ uri: 'https://mwcdn.inthecloud.ai/video/6fd96c55-190c-420c-8b0d-ca5fca4f980bMOBILITY LESSON 1_500mb_a641540df031561e2833e0436c1e411f.mp4', }} style={{ height: 200, width: 200, }} />Device