Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add visionOS support #3425

Merged

Conversation

KrzysztofMoch
Copy link
Collaborator

@KrzysztofMoch KrzysztofMoch commented Dec 18, 2023

Summary

Add experimental visionOS support

TODO:

@KrzysztofMoch KrzysztofMoch self-assigned this Dec 18, 2023
@KrzysztofMoch KrzysztofMoch changed the title feat: add visionOS support feat: add visionOS support [skip ci] Dec 18, 2023
@KrzysztofMoch KrzysztofMoch changed the title feat: add visionOS support [skip ci] feat: add visionOS support Dec 18, 2023
Copy link

@okwasniewski okwasniewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

ios/Video/RCTVideo.swift Outdated Show resolved Hide resolved
ios/Video/Features/RCTVideoDRM.swift Outdated Show resolved Hide resolved
ios/Video/Features/RCTPlayerObserver.swift Show resolved Hide resolved
ios/patches/PromisesObjC.podspec Show resolved Hide resolved
ios/.swiftlint.yml Outdated Show resolved Hide resolved
@KrzysztofMoch KrzysztofMoch marked this pull request as ready for review January 6, 2024 19:08
@KrzysztofMoch KrzysztofMoch force-pushed the feat/add-visionos-support branch 2 times, most recently from 7cffc5d to c984179 Compare January 6, 2024 19:33
@KrzysztofMoch

This comment was marked as resolved.

ios/Video/Features/RCTPlayerObserver.swift Show resolved Hide resolved
ios/Video/Features/RCTVideoDRM.swift Outdated Show resolved Hide resolved
ios/Video/Features/RCTVideoDRM.swift Outdated Show resolved Hide resolved
ios/Video/Features/RCTVideoDRM.swift Outdated Show resolved Hide resolved
@KrzysztofMoch KrzysztofMoch merged commit cf3ebb7 into TheWidlarzGroup:master Jan 15, 2024
6 checks passed
@KrzysztofMoch KrzysztofMoch deleted the feat/add-visionos-support branch January 15, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants