feat: move require (local files) to source.uri
#3535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freeboub
requested changes
Feb 15, 2024
KrzysztofMoch
changed the title
source.urisource.uri
KrzysztofMoch
commented
Feb 16, 2024
src/utils.ts
Outdated
Comment on lines
8
to
31
| // This is deprecated, but we need to support it for backward compatibility | ||
| if (typeof source === 'number') { | ||
| return { | ||
| uri: Image.resolveAssetSource(source).uri, | ||
| }; | ||
| } | ||
|
|
||
| if (typeof source.uri === 'number') { | ||
| return { | ||
| ...source, | ||
| uri: Image.resolveAssetSource(source.uri).uri, | ||
| }; | ||
| } | ||
|
|
There was a problem hiding this comment.
@freeboub In stand of making breaking change I will leave old option and add reference in docs to use new way. With this we won't have to make breaking change
No native side change ?
Yes as you can see, we earlier converted require into { uri: "some uri to local file" } so basically I've just added one if statement
KrzysztofMoch
force-pushed
the
feat/move-require-to-uri
branch
from
f2681e6
to
492f86d
Compare
|
@KrzysztofMoch finally successfully tested ! :) |
freeboub
approved these changes
Mar 12, 2024
Good idea, I have added this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
From now "local files" that are imported via
requirewill be passed insource.uriMotivation
This will unblock video config for local files
Changes
changed
resolveAssetSourceForVideofunction (JS side change only)Test plan