fix(ios): Do not crash when accessLog return nil #3549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KrzysztofMoch
requested changes
Feb 28, 2024
accessLog method can return nil if no logging information are currently available (see https://developer.apple.com/documentation/avfoundation/avplayeritem/1388499-accesslog). So we handle this case & do not call onVideoBandwidthUpdate fix TheWidlarzGroup#3424
gkueny
force-pushed
the
fix/3424-onBandwidthUpdate-crash
branch
from
7b8bcda
to
ce938e7
Compare
|
@KrzysztofMoch thanks for the review.
For my own knowledge, do you know how I can trigger |
freeboub
approved these changes
Feb 28, 2024
KrzysztofMoch
approved these changes
Feb 29, 2024
There was a problem hiding this comment.
@gkueny I am not sure... 😅 - it's sometimes just work for me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
accessLog method can return nil if no logging information are currently available (see https://developer.apple.com/documentation/avfoundation/avplayeritem/1388499-accesslog).
Motivation
should fix #3424
Changes
I handle the case where
accessLogreturnnil& do not call onVideoBandwidthUpdate if it'snil. That should avoid some crash.Test plan
Sadly I can not reproduce the crash. I did not find a way to trigger
onVideoBandwidthUpdate. Someone maybe can point me a way to reproduce this beahavior ?