fix(ios) add to validTextTracks only if we successfully insertTimeRage #3557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkueny
force-pushed
the
fix/avoid-crash-video-on-bad-subtitle
branch
from
f0e32d4
to
9efbebb
Compare
gkueny
commented
Mar 1, 2024
insertTimeRage can fail & if we add failed textTrack to our validTextTracks array, video can crash later on selectTextTrack we also add en empty textTrack only we we have validTextTrack related to TheWidlarzGroup#3480
gkueny
force-pushed
the
fix/avoid-crash-video-on-bad-subtitle
branch
from
9efbebb
to
682be95
Compare
|
You cooked 🔥 let me test it 👀 |
KrzysztofMoch
approved these changes
Mar 4, 2024
Just to be sure that there's no misunderstanding, my PR do not really fix #3480 (comment) because sideloaded subtitle will not be shown to user I just prevented the crash I still haven't found out why |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
insertTimeRage can fail & if we add failed textTrack to our validTextTracks array, video can crash later on selectTextTrack
we also add en empty textTrack only we we have validTextTrack
related to #3480
Summary
Error #3480 with sideLoaded textTrack happen because
textCompTrack.insertTimeRangefail, but we already have added textTrack to our
validTextTracksarray.Later, when we
setSelectedTextTrackthis cause video to crash.Motivation
This change do not fix the side loaded textTrack issue, but prevent video crash because of them
Changes
textTracktovalidTextTracksonly iftextCompTrack.insertTimeRangerun successfully.textTrackif we have novalidTextTrackshandled (act the same if use give notextTracks)Test plan
yarn add react-native-video@https://github.com/gkueny/react-native-video.git#f0e32d45846003f14680a5292e42a263df2f52b3