fix(android): keep screen on fullscreen #3563
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
add KEEP_SCREEN_ON flag when video is fullscreen & playing to avoid phone to go off.
Motivation
On some Android, phone can go off while video is playing in fullscreen
see #3552
Changes
While we are in fullscreen, we check each
200ms
if video is playing or not.FLAG_KEEP_SCREEN_ON
to fullscreen viewFLAG_KEEP_SCREEN_ON
from fullscreen viewTest plan
Setup sleep mode of your real android device to 15s
Install https://github.com/gkueny/FullScreenModeTurnOffAndroidReproduction
run it on an real android device
Install the patch
run it on an real android device
Update code to set
preventsDisplaySleepDuringVideoPlayback
to false & run it on an real android device