Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): don't crop video when in repeat mode #3575

Merged

Conversation

KrzysztofMoch
Copy link
Collaborator

Summary

Disable seek tolerance when seeking to start of video in repeat mode

Motivation

Without this "heavy" videos are not start from zero

Changes

  • Disabled seek tolerance
  • Moved applyModifiers to completionHandler to avoid de-synchronisation

Test plan

  • Tested in basic example

@freeboub freeboub merged commit 90b31af into TheWidlarzGroup:master Mar 10, 2024
6 checks passed
@KrzysztofMoch KrzysztofMoch deleted the fix/ios-repeat-crop branch March 13, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants