fix(ios): split licenseUrl and loadedLicenseUrl #3578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
licenseUrl: comes from props loadedLicenseUrl: comes from m3u file
This was referenced Mar 10, 2024
KrzysztofMoch
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix(ios): split licenseUrl and loadedLicenseUrl in getLicense callback
Motivation
Fix regression introduced by: https://github.com/react-native-video/react-native-video/pull/3261/files#diff-47acdf240bd5c99e4a92a2670ee3cf168a8bef94be89eb1fefbc15df20088cdd
will fix following issue: #3406
Changes
Split props in getLicense callback licenceUrl was used for multiple purpose, it was causing regressions in existing implementations
licenseUrl: comes from props
loadedLicenseUrl: comes from m3u file
Test plan
Cannot be provided as I cannot find free to used fairplay samples