Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(ios): fix real time issue when fast zapping #3582

Merged
merged 4 commits into from
Mar 14, 2024

Conversation

freeboub
Copy link
Collaborator

Summary

fix real time issue when fast zapping
When user changes stream url very quicky, sometimes stream is not released and multiple playback are ongoing in the same time

Motivation

Have a correct behavior ...

Changes

Save information when a stream start is in progress and buffer next request to apply it later

  • add safety checks in the sample
  • fix delay implementation (current implement doesn't work, but it is not really used ...)

Test plan

very fast channel up in the sample

Copy link
Collaborator

@KrzysztofMoch KrzysztofMoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, well done 🙌

@KrzysztofMoch KrzysztofMoch merged commit 429fddf into master Mar 14, 2024
8 checks passed
@KrzysztofMoch KrzysztofMoch deleted the fix/iosFixRealTimeIssueWhenFastZapping branch March 14, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants