Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): fix PiP callback #3601

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

gkueny
Copy link
Contributor

@gkueny gkueny commented Mar 23, 2024

Summary

onPictureInPictureStatusChanged PiP callback was called twice after PiP exit with bad value, this should be fixed.

onRestoreUserInterfaceForPictureInPictureStop was never called, this should be fixed.

Motivation

should fix #3598 & #3501

Changes

  • We rename internal call back toonPictureInPictureEnter & onPictureInPictureExit for better understanding
  • We do not call onPictureInPictureStatusChanged twice on PiP exit
  • We do call onRestoreUserInterfaceForPictureInPictureStop on PiP exit

Test plan

yarn add react-native-video@https://github.com/gkueny/react-native-video.git#20d1576c373ba81718c6788498e26cacd4d963e3
  • Check that issues are fixed

@gkueny
Copy link
Contributor Author

gkueny commented Mar 25, 2024

I will test this change in our project. I will adjust this PR if needed after that

@gkueny gkueny marked this pull request as draft March 25, 2024 10:46
We rename internal call back to XXXEnter & XXXExit for better understanding
We do not call StatusChanged twice on PiP exit
We do call onRestoreUserInterfaceForPictureInPictureStop on PiP exit

should fix TheWidlarzGroup#3598 & TheWidlarzGroup#3501
@gkueny gkueny marked this pull request as ready for review March 25, 2024 10:59
@KrzysztofMoch KrzysztofMoch merged commit bb9e7eb into TheWidlarzGroup:master Mar 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][iOS]: onRestoreUserInterfaceForPictureInPictureStop is never called
2 participants