fix(ios): call PictureInPicture callbacks with native controls #3603
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When we enter PiP from native controls,
onPictureInPictureStatusChanged
is never called.When we exit PiP after enter from native controls,
onPictureInPictureStatusChanged
&onRestoreUserInterfaceForPictureInPictureStop
are never called.Should fix #3602
Motivation
Be notified when PictureInPicture status changed no matter how you enter this mode.
Has
onRestoreUserInterfaceForPictureInPictureStop
callback fire no matter how you exit PiP mode.Changes
We add RCTPlayerObserver as playerViewController delegate to be notified with PiP lifecycle
Test plan
onPictureInPictureStatusChanged
is called if you enter PiP mode from native controlsonPictureInPictureStatusChanged
is called if you exit PiP mode after enter it from native controlsonRestoreUserInterfaceForPictureInPictureStop
is called if you exit PiP mode after enter it from native controls