feat!(ios): remove native dependency promises
#3631
Merged
+673
−772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KrzysztofMoch
force-pushed
the
feat/remove-ios-native-dependency
branch
from
0569f39
to
1de14c7
Compare
KrzysztofMoch
changed the title
promisespromises
KrzysztofMoch
force-pushed
the
feat/remove-ios-native-dependency
branch
from
e2130c7
to
4586233
Compare
|
It is generally ready for review, but I need to test tvOS an visionOS now |
freeboub
reviewed
Mar 31, 2024
| } | ||
| } catch {} |
There was a problem hiding this comment.
maybe add a log here in case of error ?
|
No i wasn't able to find any example stream |
|
@YangJonghun @facugu1998 do you have DRM (FairPlay) stream and could test it ? |
|
@freeboub @KrzysztofMoch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove native iOS dependency
promisesand migrate to async/awaitMotivation
We internally discussed that we should remove this dependency as we can go without it.
promisesalso required privacy manifest, so generally it should be easier for us in future to go without it.Changes
min version bumped
Test plan
basicexample