fix: fix codegen types #3636
Merged
fix: fix codegen types #3636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freeboub
approved these changes
Mar 31, 2024
|
So folks from expo team told me that we cannot use codegen with Interop Layer - so I propose to temporary disable it. We will turn on it after we migrate to new architecture |
|
@KrzysztofMoch changes looks good to me. Don't you think the codegen removal (temporary) should be done in another PR ? It would be easier to revert. |
KrzysztofMoch
force-pushed
the
fix/codegen
branch
from
3c9c236
to
c6c19cf
Compare
|
Sure so I will make separate PR for disabling it 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix codegen by changing types to supported one as it does not support string unions
Motivation
Fix compatibility with codegen
Changes
Test plan