Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure poster works as expected and add it to the sample #3643

Merged
merged 8 commits into from
Apr 5, 2024
Merged

fix: ensure poster works as expected and add it to the sample #3643

merged 8 commits into from
Apr 5, 2024

Conversation

freeboub
Copy link
Collaborator

@freeboub freeboub commented Apr 2, 2024 •
edited

Summary

Fix poster behavior:

  • avoid updating state when no poster is provided (avoid unnecessary refreshes)
  • ensure poster is display is well reset at stream start
  • add demo un basic sample
  • doc: remove audioOnly property as not implemented on any platform

Motivation

Test plan

  • to be tested with sample

@freeboub freeboub merged commit d694139 into TheWidlarzGroup:master Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrzysztofMoch KrzysztofMoch KrzysztofMoch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Poster not working on android
2 participants
@freeboub @KrzysztofMoch