fix(ios): do not save pause state before seeking #3650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KrzysztofMoch
approved these changes
Apr 3, 2024
|
I just fixed conflict, regarding to android implmentation, this issue is not available (diffferent behavior) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Do not save paused state before seeking.
If user change paused prop during seek, it will not be applied (as a pause is done before seeking)
Motivation
we can have a kind of race condition if user change paused prop during the seek, the initial value will be applied
address ticket: #3644
Changes
Test plan
Tested by changing the sample to seek at 0 and pause in onEnd callback
see comment: #3644 (comment)