Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): apply PictureInPicture state on start #3655

Merged
merged 1 commit into from
Apr 5, 2024
Merged

fix(ios): apply PictureInPicture state on start #3655

merged 1 commit into from
Apr 5, 2024

Conversation

KrzysztofMoch
Copy link
Collaborator

@KrzysztofMoch KrzysztofMoch commented Apr 5, 2024 •
edited

Summary

Fixed PiP on iOS where it couldn't possible to disable PiP

Motivation

Changes

  • apply pip state on init

Test plan

  • Tested locally
  • CI pass

@KrzysztofMoch KrzysztofMoch merged commit 07f71c2 into TheWidlarzGroup:master Apr 5, 2024
6 checks passed
@KrzysztofMoch KrzysztofMoch deleted the fix/ios-pip branch April 5, 2024 08:37
@YangJonghun
Copy link
Collaborator

YangJonghun commented Apr 10, 2024 •
edited

@KrzysztofMoch
Hi!
pictureInPicture prop changed from false to true, it assign new _pip every time. I think it may cause some bug.
Also, the assignment of allowsPictureInPicturePlayback within init is duplicated with createPlayerViewController.

@KrzysztofMoch
Copy link
Collaborator Author

@YangJonghun you right 👀 good catch! - will make PR to address this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freeboub freeboub freeboub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Can't disable Picture in Picture
3 participants
@KrzysztofMoch @YangJonghun @freeboub