Fix/ensure tracks are available in sample #3660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KrzysztofMoch
approved these changes
Apr 7, 2024
|
I am indeed seeing the subtitles now in the sample :D for "sintel with subtitles" but not for "sintel with sideLoaded subtitles"! Nice work y'all on latest master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ensure tracks are available correctly for the app.
onAudioTracks event was reporting some null value
Motivation
Review behavior from: #3642
This is only a partial fix, we still need to review extranally loaded text tracks
Changes
mainly ensure onTextTracks return good value
remove unused function
improve sample
Test plan
can be tested on sample