Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): set title for external subtitles #3676

Merged
merged 1 commit into from
Apr 14, 2024
Merged

fix(android): set title for external subtitles #3676

merged 1 commit into from
Apr 14, 2024

Conversation

KrzysztofMoch
Copy link
Collaborator

@KrzysztofMoch KrzysztofMoch commented Apr 12, 2024 •
edited

Summary

fix issue with title getter in exoplayerTrackToGenericTrack

Motivation

fixes #3663

Changes

  • changed exoplayerTrackToGenericTrack function to get value from label instead of id

Test plan

  • Tested locally
  • CI passes

@KrzysztofMoch KrzysztofMoch merged commit 336b9f0 into TheWidlarzGroup:master Apr 14, 2024
3 checks passed
@KrzysztofMoch KrzysztofMoch deleted the fix/android-subtitle branch April 14, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freeboub freeboub freeboub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Title is null when sidecar text tracks loaded
2 participants
@KrzysztofMoch @freeboub