Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix/performOnPlayerViewCrash #3685

Merged

Conversation

JinYuSha0
Copy link
Contributor

Summary

04-17 18:25:33.400 25186 25186 E AndroidRuntime: com.facebook.react.uimanager.IllegalViewOperationException: Trying to resolve view with tag 2947 which doesn't exist
04-17 18:25:33.400 25186 25186 E AndroidRuntime: 	at com.facebook.react.uimanager.NativeViewHierarchyManager.resolveView(SourceFile:38)
04-17 18:25:33.400 25186 25186 E AndroidRuntime: 	at com.facebook.react.uimanager.UIManagerModule.resolveView(SourceFile:14)
04-17 18:25:33.400 25186 25186 E AndroidRuntime: 	at com.brentvatne.react.VideoManagerModule.performOnPlayerView$lambda$0(SourceFile:23)
04-17 18:25:33.400 25186 25186 E AndroidRuntime: 	at com.brentvatne.react.VideoManagerModule.O000O0O00OO0O0OOO0O(SourceFile:1)
04-17 18:25:33.400 25186 25186 E AndroidRuntime: 	at com.brentvatne.react.O000O0O00OO0O0OOO0O.run(SourceFile:1)
04-17 18:25:33.400 25186 25186 E AndroidRuntime: 	at android.os.Handler.handleCallback(Handler.java:938)
04-17 18:25:33.400 25186 25186 E AndroidRuntime: 	at android.os.Handler.dispatchMessage(Handler.java:99)
04-17 18:25:33.400 25186 25186 E AndroidRuntime: 	at android.os.Looper.loop(Looper.java:246)
04-17 18:25:33.400 25186 25186 E AndroidRuntime: 	at android.app.ActivityThread.main(ActivityThread.java:8633)
04-17 18:25:33.400 25186 25186 E AndroidRuntime: 	at java.lang.reflect.Method.invoke(Native Method)
04-17 18:25:33.400 25186 25186 E AndroidRuntime: 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:602)
04-17 18:25:33.400 25186 25186 E AndroidRuntime: 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1130)

Quickly switching videos will cause a crash because uiManager?.resolveView cannot obtain the view

Motivation

fix crash bug

Changes

Test plan

Copy link
Collaborator

@KrzysztofMoch KrzysztofMoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense 👍

@KrzysztofMoch KrzysztofMoch merged commit 3e35326 into TheWidlarzGroup:master Apr 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants