Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(android): implement asset folder playback #3733

Conversation

freeboub
Copy link
Collaborator

@freeboub freeboub commented May 4, 2024

Summary

Feature: implement playback ability from app asset folder

Motivation

Fix: #2825

Changes

  • remove some used functions
  • Implement playback with DataSource.Factory from asset

Test plan

  • sample video asset added in the sample app

@freeboub
Copy link
Collaborator Author

freeboub commented May 4, 2024

And thank you @evoactivity for the link !

Copy link
Collaborator

@KrzysztofMoch KrzysztofMoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙌

@KrzysztofMoch KrzysztofMoch merged commit e05da4e into TheWidlarzGroup:master May 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Read the video from android asset folder
2 participants