Fix(android): avoid video resizing flickering #3751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oplayerView code size
…ideo # Conflicts: # android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerViewManager.java # src/Video.tsx
freeboub
changed the title
|
It is still possible to reproduce flickering. |
Thank you for the feedback, I didn't focus on selectedVideoTrack, but it is my plan soon ! :) |
…fix/avoidVideoResizingFlickering # Conflicts: # .github/ISSUE_TEMPLATE/bug-report.yml
|
Lets merge, @freeboub I will leave you fixing selectedVideoTrack case |
|
Yes, it was fixed in v6.0.0-rc.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
resize video View when we receive the list of video tracks instead of resizing it when the video is displayed
Motivation
Fix video flickering when starting playback: #3740 and #3653
Changes
resize video View when we receive the list of video tracks instead of resizing it when the video is displayed
Test plan
can be tested with the sample app