New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(android): hide seekBar for props ( can be used for live broadcast) #3789

Merged

KrzysztofMoch merged 19 commits into TheWidlarzGroup:master from seyedmostafahasani:feat/hide-android-seekBar

May 20, 2024

Contributor

seyedmostafahasani commented May 17, 2024 •

edited

Summary

Motivation

My goal was to address an issue with the excellent library on Android devices.

Changes

I introduced a new property called hideSeekBar to manage the visibility of the seekBar when the controls property is set to true.

Test plan


          feat: hide seekBar on Android when a video is a live broadcast

e9be3e0

freeboub requested changes

View reviewed changes

Collaborator

freeboub left a comment

Thank you for the PR, I think this is a requested feature !
I gave you some feedback about code organization ... Sorry

Additionally can you add the new prop into the documentation please ?

android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java Outdated Show resolved Hide resolved

android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerViewManager.java Outdated Show resolved Hide resolved

seyedmostafahasani added 2 commits

May 17, 2024 17:28


          refactor: prop name & code

b1a6ddd


          chore: update the document for a new prop (controlsStyles)

deca62f

seyedmostafahasani requested a review from freeboub

May 17, 2024 14:15

Contributor Author

seyedmostafahasani commented May 17, 2024

@freeboub I've applied all of your comments. Could you please check it out and confirm if everything looks good now?

freeboub requested changes

View reviewed changes

Collaborator

freeboub left a comment

Only cosmetic issue remaining, thank you for the quick handling of feedback !

android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java Outdated Show resolved Hide resolved

android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java Outdated Show resolved Hide resolved

android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java Outdated Show resolved Hide resolved

android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerViewManager.java Outdated Show resolved Hide resolved

android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerViewManager.java Outdated Show resolved Hide resolved

android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerViewManager.java Outdated Show resolved Hide resolved

docs/pages/component/props.mdx Outdated Show resolved Hide resolved

docs/pages/component/props.mdx Outdated Show resolved Hide resolved

docs/pages/component/props.mdx Outdated Show resolved Hide resolved


          refactor: code

80fb357

seyedmostafahasani requested a review from freeboub

May 17, 2024 15:34

freeboub requested changes

View reviewed changes

Collaborator

freeboub left a comment

Sorry for the painful feedback ...
Did you see the command yarn check-android
It may fix automatically the issue !

android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java Outdated Show resolved Hide resolved

android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java Outdated Show resolved Hide resolved

android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java Outdated Show resolved Hide resolved

android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java Outdated Show resolved Hide resolved

android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java Show resolved Hide resolved

android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerViewManager.java Outdated Show resolved Hide resolved

android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerViewManager.java Outdated Show resolved Hide resolved

freeboub changed the title ~~feat: hide seekBar on Android when a video is a live broadcast~~ feat(android): hide seekBar for props ( can be used for live broadcast)

seyedmostafahasani added 2 commits

May 17, 2024 19:50


          remove: additional variables

76dec53


          fix: indent issues

b95083d

Contributor Author

seyedmostafahasani commented May 17, 2024

@freeboub I hope the indent issue has been fixed.

seyedmostafahasani requested a review from freeboub

May 17, 2024 16:43

freeboub requested changes

View reviewed changes

android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerViewManager.java Show resolved Hide resolved

freeboub reviewed

View reviewed changes

android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerViewManager.java Outdated Show resolved Hide resolved

seyedmostafahasani and others added 2 commits

May 17, 2024 20:24


          remove: duplicate function

d48e43d


          Update android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerV…

…iewManager.java


revert change1

freeboub reviewed

View reviewed changes

android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerViewManager.java Outdated Show resolved Hide resolved

freeboub and others added 2 commits

May 17, 2024 18:54


          Update android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerV…

…iewManager.java


revert change2


          Merge remote-tracking branch 'origin/feat/hide-android-seekBar' into …

a75c47b

…feat/hide-android-seekBar

freeboub reviewed

View reviewed changes

android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerViewManager.java Outdated Show resolved Hide resolved


          Update android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerV…

672eed7

…iewManager.java

freeboub requested changes

View reviewed changes

android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerViewManager.java Outdated Show resolved Hide resolved

android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerViewManager.java Outdated Show resolved Hide resolved

android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerViewManager.java Outdated Show resolved Hide resolved

android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerViewManager.java Outdated Show resolved Hide resolved

freeboub added 4 commits

May 17, 2024 18:57


          Update android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerV…

45faed3

…iewManager.java


chore: revert indent change


          Update android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerV…

774d73f

…iewManager.java


chore: revert indent change


          Update android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerV…

dd47882

…iewManager.java


chore: revert indent change


          Update android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerV…

ed83aed

…iewManager.java


chore: revert indent change

freeboub reviewed

View reviewed changes

android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerViewManager.java Outdated Show resolved Hide resolved

freeboub and others added 3 commits

May 17, 2024 18:57


          Update android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerV…

abc3e1d

…iewManager.java


chore: revert indent change


          fix: eslint errors


          Merge remote-tracking branch 'origin/feat/hide-android-seekBar' into …

ec80c88

…feat/hide-android-seekBar

freeboub reviewed

View reviewed changes

android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java Outdated Show resolved Hide resolved

freeboub reviewed

View reviewed changes

android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java Outdated Show resolved Hide resolved


          Update android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerV…

5633bfc

…iew.java


chore: revert indent change

freeboub approved these changes

View reviewed changes

freeboub requested a review from KrzysztofMoch

May 17, 2024 16:59

KrzysztofMoch approved these changes

View reviewed changes

KrzysztofMoch merged commit 95e6140 into TheWidlarzGroup:master

6 checks passed

seyedmostafahasani deleted the feat/hide-android-seekBar branch

June 2, 2024 19:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment