fix(android): refactor source, fix random DRM issue and crop start on local asset #3835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oplayerView code size
…ideo # Conflicts: # android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerViewManager.java # src/Video.tsx
…fix/avoidVideoResizingFlickering # Conflicts: # .github/ISSUE_TEMPLATE/bug-report.yml
Also fix a side issue when using a local file cropping props were not applied Also fix random DRM issue by refactoring initializePlayerSource TheWidlarzGroup#3082
freeboub
commented
May 24, 2024
YangJonghun
reviewed
May 24, 2024
YangJonghun
reviewed
May 27, 2024
android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java
Outdated
Show resolved
Hide resolved
…ideo into fix/refactorSource # Conflicts: # android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java
YangJonghun
approved these changes
May 28, 2024
KrzysztofMoch
approved these changes
May 28, 2024
|
@freeboub - eventEmitter.error("Failed to initialize DRM Session Manager Framework!", new Exception("DRM Session Manager Framework failure!"), "3003"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Move source prop in a dedicated class
Motivation
Keep code clean and more split
In the same time I fix:
Also fix a side issue when using a local file cropping props were not applied
Also fix random DRM issue by refactoring initializePlayerSource : #3082
Prepare another refactor to fix: #2693 and #3665
Changes
Move parsing of source in a dedicated class
Rework usage of the source
Rework MediaMetadata initialization (ping @KrzysztofMoch)
merge setSrc and setRawSrc
Add missing clearResumePosition(); in setSrc
improve logs
Test plan
Can be tested with the sample