Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues that arise due to accessing _player on a queue other than main #70

Merged
merged 6 commits into from Jul 1, 2015

Conversation

isair
Copy link
Contributor

@isair isair commented Jun 29, 2015

For more information on why this is being done: #66 (comment)

Also renamed the method playerDidEnd as playerDidReachEnd.

@isair isair changed the title Call player methods and access its attributes on main queue [WIP] Call player methods and access its attributes on main queue Jun 29, 2015
@isair
Copy link
Contributor Author

isair commented Jun 29, 2015

@brentvatne I need some clarification on a matter. Based on the fact that calling [_player pause] on the main queue has fixed the problem I mentioned in #66, I assumed react-native didn't call property setters just on the main thread. However, if that was the case, then there should have been problems with setSrc as well. There is no information in React Native's native UI component documentation, so I hope maybe you can shed some light on this.

@isair
Copy link
Contributor Author

isair commented Jul 1, 2015

@brentvatne Merging this as-is without modifying the setSrc method as I haven't ran into a bug about it so far. Could this whole async business be a bug with react-native as it isn't mentioned in the docs?

@isair isair changed the title [WIP] Call player methods and access its attributes on main queue Call player methods and access its attributes on main queue Jul 1, 2015
@isair isair changed the title Call player methods and access its attributes on main queue Fix issues that arise due to accessing _player on a queue other than main Jul 1, 2015
isair added a commit that referenced this pull request Jul 1, 2015
Fix issues that arise due to accessing _player on a queue other than main
@isair isair merged commit dae2ea2 into master Jul 1, 2015
@isair isair deleted the fix/player-access branch July 1, 2015 21:17
@brentvatne
Copy link
Contributor

Hey @isair sorry for the delay on getting back to you here - I'm actually not sure about whether or not setSrc would need to be called on the main thread. @johanneslumpe do you have any insight on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants