Call setRate instead of pause/play as they are equivalent #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This makes sense to me, @johanneslumpe what do you think? |
dpeek
force-pushed
the
fix/paused-resumes-after-seek
branch
from
340d6fa
to
27b8180
Compare
…idlarzGroup#75) Video was resuming after seek when setRate was called after play/pause in applyModifiers. According to Apple's docs play/pause are equivalent to setRate:1.0 and setRate:0.0, meaning that if rate was 1.0 the video resumed after seeking completed.
dpeek
force-pushed
the
fix/paused-resumes-after-seek
branch
from
27b8180
to
153eb59
Compare
|
Seems logical for me as well. Haven't tested but sounds like this might fix #73 too. Edit: By the way, @dpeek, the Edit 2: @brentvatne I can confirm that this fixes #73, at least in my project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Video was resuming after seek when setRate was called after play/pause in applyModifiers. According
to Apple's docs play/pause are equivalent to setRate:1.0 and setRate:0.0, meaning that if rate was
1.0 the video resumed after seeking completed.