Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export emojis data #142

Merged
merged 15 commits into from
Jul 2, 2023
Merged

feat: export emojis data #142

merged 15 commits into from
Jul 2, 2023

Conversation

mateki0
Copy link
Contributor

@mateki0 mateki0 commented Jun 19, 2023

No description provided.

@mateki0 mateki0 requested a review from jakex7 June 19, 2023 15:44
@mateki0 mateki0 changed the title Feat/export emojis data feat: export emojis data Jun 19, 2023
@mateki0
Copy link
Contributor Author

mateki0 commented Jun 21, 2023

Hi @ginsueddy, I've seen your feature request for exported emoji data that you can work with. Is the solution proposed by me in this PR ok for you or you wanted something else?

@ginsueddy
Copy link

Hey @mateki0 this is a great first step, and actually helps me out a lot on the project I am building that uses rn-emoji-keyboard. Eventually it would be really nice to completely decouple the data from the EmojiKeyboard and EmojiPicker components and introduce a data prop for both of those components where the dev can import your data and pass it as a prop to the components. For our web app we use this web emoji keyboard library and they decoupled the data, and it is nice because it gives the developers the flexibility to better control their bundle size and how the data should be imported. But again this is really helpful and unblocks me a ton, and I really appreciate how fast you guys took the feedback and implemented the changes!

Copy link
Member

@jakex7 jakex7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've applied the same pattern as in other default values in context

@jakex7 jakex7 merged commit dba181b into master Jul 2, 2023
3 checks passed
@jakex7 jakex7 deleted the feat/export-emojis-data branch July 2, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants