Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deepMerge util #166

Merged
merged 3 commits into from
Jan 31, 2024
Merged

fix: deepMerge util #166

merged 3 commits into from
Jan 31, 2024

Conversation

jakex7
Copy link
Member

@jakex7 jakex7 commented Jan 31, 2024

Fixes the types and functionality of deepMerge util.

Changes:


In the previous implementation, deepMerge styles didn't work with arrays and tried to merge even nested styles. Currently, it only merges to the level that is in the source. Example:

{
  container: { backgroundColor: '#000' },
  emoji: {
    selected: {
      backgroundColor: '#000',
      transform: [{ rotate: '45deg' }],
    },
  },
}

Copy link
Collaborator

@DominikDanielewicz DominikDanielewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@jakex7 jakex7 merged commit c17f39c into master Jan 31, 2024
3 checks passed
@jakex7 jakex7 deleted the fix/deepMerge branch January 31, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants