Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

Big refactorings #9

Merged
merged 7 commits into from
May 25, 2017
Merged

Big refactorings #9

merged 7 commits into from
May 25, 2017

Conversation

orf
Copy link
Contributor

@orf orf commented May 25, 2017

I took a stab at doing some refactoring and it appears to work fine. I replaced the shell=True calls (they are not needed with this, perhaps on Windows they where) and added a call wrapper to print what is currently running.

I made all the call calls use arrays, which gets around the quoting issues that you experience if you use shell=true and manually concatenate strings together.

I got rid of the hard-coded ************* headers for each stage and added a function that deals with them dynamically. I also ran an auto-formatter on the code to make it more pythonic, hence the horrible diff. Sorry!

Grab a copy of the script from my branch here: https://github.com/orf/apk2java-linux/blob/patch-1/apk2java.py

Give it a test and if it's OK then merge 👍 feel free to ask me any questions

~~Currently this doesn't work with APK's that have a space in them. No big deal I guess, but I figured I would try and refactor the code to use subprocess.call properly rather than just concating strings everywhere.~~~

Edit: also, thanks for this script, it's pretty damn good!

@orf orf changed the title Small refactorings Big refactorings May 25, 2017
Copy link
Owner

@TheZ3ro TheZ3ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, nice work! This will also need a tool upgrade I think, lots of tools here are outdated

@TheZ3ro TheZ3ro merged commit 3f2e412 into TheZ3ro:master May 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants