Adopt from_* naming convention for classmethods
#24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akoen
requested changes
Dec 18, 2023
paulromano
force-pushed
the
classmethod-naming
branch
from
8de230f
to
70a054b
Compare
|
@akoen I've added back the older names as deprecated aliases (users will get a |
akoen
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #23, please review/merge that first
Many Python packages use a convention whereby a
@classmethodcalledfrom_*is an "alternate constructor" that returns a new instance of the class. To note a few examples:int.from_bytesfractions.Fraction.from_decimalpandas.DataFrame.from_dictnumpy.fromiteropenmc.Plane.from_pointsThis PR adopts this convention for the
GeometryandMeshclasses.